Module: Movie overlay

Thanks for a cool module! I wanted to point out, however, that the top and left settings don't work because the value of '80px' is hard-coded into movie_overlay_theme.php. I was able to fix this by changing the following lines:

top:80px;
left:80px;

to

top:".$top."px;
left:".$left."px;

windracer,
Thanks for that. It must have been a Monday or a Friday
I just downloaded this module again and find that some of the icons are not well done.
Anybody care to help out and develop some better ones with proper transparency and not clugeged together?
Just post them here or send them in a PM and I will add them to the module. You will get credit as well on the codex, is that enough incentive?

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

There's also a typo in the module name in the theme.info file.

Just a few notes:

1) The top and left 80px's are still hard coded in movie_overlay_theme.php
2) I was looking in to this and haven't tried to mod it yet, but is there a way to say 'center' the icon?

pseudo center code:
top = ($imageheight/2 - $iconheight/2)
left = ($imagewidth/2 - $iconwidth/2)

Think I have the logic close...

Just a thought.

EDIT: Perhaps not quite that simple since it's in the stylesheet...

Fixed the top and left being 80 issue and moved the zip file to the codex.
the issue with using $imageheight/2 and $imagewidth/2 is that the thumbs for movies can be and often are of differing sizes.
I suppose it could be done giving each overlay a unique ID and then some calculation to get the thumb height and width.
Seems like a lot of work for little benefit.
If there is more call for it I might work on that.
Some HTML5 overlay might be a better option.
I think that displaying the time of the movie would be cool as well.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

I'm no UI expert and certainly not a designer, but here is movie time if you have ffmpeg installed. Not sure what the results are if ffmpeg is not available.
overwrite the file with the one below removing the _.txt extension.

I think the best way to do this is with some JS and replace the image with a <div> or tow that can be styled a bit better in the view.

Dave

_____________________________________________
Blog & G2 || floridave - Gallery Team

suprsidr, Yes I did see those and look cool. I have decided to go for a css method to fix a couple of issues I was having and perhaps go the <canvas> route in the future.
I have updated the module on the codex.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

Got a url to show the behaviour/behavior?

intaller.php was most likely a typo on my part or some beer consumption. I will fix that.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

Hmmm ... I'm using GreyDragon 3.2.2 in two different galleries and don't see that shift in the thumbnail.

cchiappa, Remove:
margin: auto;
from helpers/movie_overlay_theme.php as a temporary measure.
Seems that the GD theme overrides the core theme_view code.
Perhaps Serge can look at his override and make some adjustments for the thumb_bottom function placement.

windracer, can you PM the URL to one so I can see the source?
It could be some other module or thumb size that has some other interaction that is causing this issue.
Are you using version 2?

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

Thanks, that does fix the problem. The overlay is still not quite right, since it looks like the positioning is relative to the frame rather than the thumb nail, but I can hack that up pretty easily.

That module doesn't work on my website. I do also use the watermark-plugin - could this be a problem? If I include a youtube-clip the "old" movieoverlay-button appears instead the new one I've chosen in the admin-settings.

Thank you Dave
It would be great approach

Serge
_____________________________________________
Photo Gallery | GreyDragon Theme | Follow on Twitter

After inactivating the module you can just delete its folder under the modules sub-directory in your G3 install.

inchains - you need the fix I posted in http://gallery.menalto.com/node/101387#comment-391309 , ie you need to rename deactivate in helpers/movie_overlay_installer.php to uninstall.

Hi,
Is there a version 3? The one I uploaded shows version 2. Thanks

Thank you.

edit the image block view file to look like:

<?php defined("SYSPATH") or die("No direct script access.") ?>
<? foreach ($items as $item): ?>
<div class="g-image-block">
<? if ($item->type == "movie") { ?>
<?= $theme->thumb_top($item) ?>
<? } ?>
  <a href="<?= url::site("image_block/random/" . $item->id); ?>">
   <?= $item->thumb_img(array("class" => "g-thumbnail")) ?>
  </a>
<? if ($item->type == "movie") { ?>
<?= $theme->thumb_bottom($item) ?>
<? } ?> 
</div>
<? endforeach ?>

Not tested much

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

The module always invokes ffmpeg on movies even if the time isn't going to be displayed. This can slow things down noticably. Trivial fix:

{~,} 
--- helpers/movie_overlay_theme.php~	2012-08-10 10:02:52.000000000 -0400
+++ helpers/movie_overlay_theme.php	2013-11-08 12:00:21.183362516 -0500
@@ -85,7 +85,8 @@
 	  $view->images_url = 	url::file("modules/movie_overlay/images");
 	  $view->icon = 		module::get_var("movie_overlay", "icon");
 	  $view->trans = 		module::get_var("movie_overlay", "trans");
-	  $view->movie_time = 	number_format(movie_overlay_theme_Core::get_movie_time($child), 2);
+         if (module::get_var("movie_overlay", "time"))
+          	  $view->movie_time = 	number_format(movie_overlay_theme_Core::get_movie_time($child), 2);
 	  return $view;
 	}
   }