ERROR_LOCK_TIMEOUT with latest dailies?
|
McRib
Joined: 2005-02-01
Posts: 13 |
Posted: Tue, 2005-02-01 08:54
|
|
Hello, first of all I want to conragtulate you to this fantastic product - it is ---- * in modules/core/classes/helpers/GalleryLockHelper_medium.class at line 424 System Information |
|
|
McRib
Joined: 2005-02-01
Posts: 13 |
Posted: Tue, 2005-02-01 10:17
|
|
P.S.: The data directory is not on NFS or other means of remote storage ... |
|
|
sddroog
Joined: 2005-02-01
Posts: 132 |
Posted: Tue, 2005-02-01 14:55
|
|
McRib wrote:
If I am adding items (no matter if "Web", "Remote" or "Applet", no matter if "generate thumbnails" ticked or not) if takes some seconds and I get the error below. Same here. No mather what I try, I can not add any items to the gallery. |
|
|
volksport
Joined: 2002-10-06
Posts: 239 |
Posted: Tue, 2005-02-01 19:21
|
|
I believe this is a lock issue that behaves differently on windows, and was created within the last few days by me. A temporary fix for windows users can be to comment out the code I added (which is simple), until a new way to create locks is created. to comment out the code, go to: at the very end of this function find this code: $alreadyLocked = GalleryCoreApi::isWriteLocked($albumId);
if(!$alreadyLocked) {
list ($ret, $lockId) = GalleryCoreApi::acquireWriteLock($albumId);
if ($ret->isError()) {
return $ret->wrap(__FILE__, __LINE__);
}
}
list ($ret, $parentAlbum) = GalleryCoreApi::loadEntitiesById($albumId);
if ($ret->isError()) {
return $ret->wrap(__FILE__, __LINE__);
}
$parentAlbum->setModificationTimestamp(time());
$ret = $parentAlbum->save();
if ($ret->isError()) {
return $ret->wrap(__FILE__, __LINE__);
}
if (!$alreadyLocked) {
$ret = GalleryCoreApi::releaseLocks($lockId);
if ($ret->isError()) {
return $ret->wrap(__FILE__, __LINE__);
}
}
on the line before the code starts add a forward slash and an asterisk: /* this *should* fix your issue for now. if it doesn't, or your computer a'splodes or something - then sorry |
|
|
McRib
Joined: 2005-02-01
Posts: 13 |
Posted: Tue, 2005-02-01 19:35
|
|
Hello Bob, like I told before tha regression is not only noticable Thanks for the quick reply, |
|
|
volksport
Joined: 2002-10-06
Posts: 239 |
Posted: Tue, 2005-02-01 19:55
|
|
yea, i didn't notice that - i tend to skim through things. I am sure someone else will chime in soon. |
|
|
virshu
Joined: 2003-09-13
Posts: 314 |
Posted: Tue, 2005-02-01 20:18
|
|
McRib, like volksport said - we can consistently see this problem on Windows, but couldn't see it on Linux... Did commenting out code block help? |
|
|
sddroog
Joined: 2005-02-01
Posts: 132 |
Posted: Tue, 2005-02-01 21:00
|
|
virshu wrote:
McRib, like volksport said - we can consistently see this problem on Windows, but couldn't see it on Linux... Did commenting out code block help? I run Linux and removing this code did help me! |
|
|
mindless
Joined: 2004-01-04
Posts: 8601 |
Posted: Tue, 2005-02-01 21:07
|
|
it will be removed from cvs today, until we resolve the underlying problem. |
|
|
McRib
Joined: 2005-02-01
Posts: 13 |
Posted: Tue, 2005-02-01 21:41
|
|
Hi guys, it did do it for me on both Windows and Linux. Thanks! |
|
|
tezza
Joined: 2004-12-07
Posts: 18 |
Posted: Sun, 2005-02-06 13:28
|
|
mindless wrote:
it will be removed from cvs today, until we resolve the underlying problem. Hello there. I'm running "nice commits" on a debian (stable) box with PHP4 and I'm getting the same error. I went searching for the abovementioned code to comment out, but it doesn not exist in my version of G2. Here is the stack Error (ERROR_LOCK_TIMEOUT) * in modules/core/classes/helpers/GalleryLockHelper_medium.class at line 425 Please let me know if I need to provide more information to assist wtih debugging this. THanks. |
|
|
mindless
Joined: 2004-01-04
Posts: 8601 |
Posted: Sun, 2005-02-06 15:38
|
|
tezza, your error is not related to this. |
|
|
tezza
Joined: 2004-12-07
Posts: 18 |
Posted: Mon, 2005-02-07 00:53
|
|
mindless wrote:
tezza, your error is not related to this. Right oh then. I've followed your advice and I've created a new topic at http://gallery.menalto.com/index.php?name=PNphpBB2&file=viewtopic&p=117383#117383 |
|
