Voting/Polling version 0.9

****UPDATE****** 13 September 2003
Voting will be part of 1.4.1 See version 1.4.1-cvs-b74 or greater. Read the last posting in this thread for notes about going from patch voting to 1.4.1 voting.
*****UPDATE*****
http://sourceforge.net/tracker/index.php?func=detail&aid=693373&group_id=7130&atid=307130

Sorry this has taken so long, but here is the latest version.

Features

<LI> it enables administrators and album owners to set up polling/opinion on a album by album basis.
<LI> Completely configurable from album properties
<LI> voting can be either rank (voters choose one 1st, one 2nd, one 3rd etc) or critique (each image is evaluated independently).
<LI> Rank voting is done using radio buttons, critiques on a pull down menu, or if th
ere is a single choice - a checkbox.
<LI> Voting results can be hidden, or displayed in summary form on the album pages, plus there is a page with complete results.
<LI> Both the displayed names and the value for each polling option is configurable for each album.
<LI> voting can be completely open (recorded against session id), or restricted to members only (using UID).
<LI> Poll can be stopped and started at will
<LI> If "nobody" can vote, and results aren't displayed, then to users the album looks exactly the way it does now.
<LI> Results are shown graphically in ranking order and in broken down form for each photo.
<LI> Graphical displays include links to each photo
<LI> Votes can be changed at any time while the poll is open
<LI> For rank voting, your current choices are displayed at the top of page one
<LI> Any number of voting options are available (including just a checkbox "I like this picture")
<LI> For rank voting, total score is based on a weighted sum of all votes
<LI> For critique voting, total score is based on the average of votes cast

**UPDATE** This code now lives at http://sourceforge.net/tracker/?func=detail&aid=693373&group_id=7130&atid=307130[/]

Have you got ssh access? If so, ftp the patch file into your gallery directory, then SSH in.

From the SSH terminal, change directory to your gallery directory (eg cd public_html/gallery), then type
patch -p0 < vote_release_candidate.patch

If you don't see any error messages, then it's time to test it.

bash-2.05$ patch -p0 < vote_release_candidate.patch
patching file util.php
patching file view_album.php
patching file view_photo.php
patching file classes/Album.php
Hunk #3 succeeded at 861 (offset -8 lines).
patching file classes/AlbumItem.php
patching file css/embedded_style.css.default
Hunk #1 FAILED at 52.
1 out of 1 hunk FAILED -- saving rejects to file css/embedded_style.css.default.
rej

i got it working it looks great! but when you vote it displays this
Poll results: th place overall.

is what i get when i run the patch...i hope it works

That's ok! It means your warning text won't be blue - but I think you can live with that.

Known behaviour - though it looks like it should be fixed. The Rank is only recalculated when drawing the thumbnail page. If you go to the thumbnail page, then back to the image page, you should get a correct value.

Now you know why it's version 0.9!

I just downloaded that version. The patch works.

It doesn't sound like you are in the right directory. Patch will fail if it can't find the named files.

You need to run the patch in the gallery directory, ie the same directory that albums.php etc are in.

eg
cp Desktop/downloads/vote_release_candidate.zip public_html/gallery
cd public_html/gallery
unzip vote_release_candidate.zip
patch -p0 < vote_release_candidate.patch

can you email me one of your files, say classes/AlbumItem.php? Run zip or gzip on it first, so it doesn't get converted in anyway. email it to gallery @ mcgalliard.freeuk.com

[I tried the experiment again (this time on a Linux machine), unpacking a fresh gallery from gallery.1.3.4-cvs-b15.tar.gz. My patch ran fine. As yours failed on every change, my guess is that your repository and mine differ in some way on every single line, so what I am looking for is DOS line feeds on every line, or something similar.]

Nevermind Joan... I pulled out my old 1st grade math book and think I figured it out :grin:

Bug fix:

Open poll_properties.php. Everywhere it says "Everyone" replace it with "Everybody". That's three changes.

Then open util.php. Replace getVotingID and canVote with these versions.
<!-- BBCode Start --><TABLE BORDER=0 ALIGN=CENTER WIDTH=85%><TR><TD><font class="pn-sub">Code:</font><HR></TD></TR><TR><TD><FONT class="pn-sub"><PRE>
function getVotingID()
{
global $gallery;
if ($gallery->album->getVoterClass() == "Logged in")
{
return $gallery->user->getUid();
}
else if ($gallery->album->getVoterClass() == "Everybody")
{
return session_id();
}
else
{
return NULL;
}

}
function canVote()
{
global $gallery;
if ($gallery->album->getVoterClass() == "Everybody")
{
return true;
}
if ($gallery->album->getVoterClass() == "Logged in"
&amp;&amp; $gallery->user->isLoggedIn())
{
return true;
}
return false;
}
</TD></TR></TABLE><!-- BBCode End -->

Ok the edits have been made.

When I made the edits it did change "Everybody" to logged in..but I've updated that back to everybody.

Would you like to re-test?

Everything's looking good to me .. but what do I know? LOL

Well so far I'm THRILLED to have this feature. Again THANK YOU for continuing to work on it!!!!

You've done great :smile:

If I had a feature request it would simply be the ability to "Apply properties to all sub-albums".

Overall this is a great addition and kudos for the ease of installation!!!

latest version is <!-- BBCode Start --><A HREF="http://www.mcgalliard.org/content/gallery/vote_release_candidate_0.9.1.zip" TARGET="_blank">vote_release_candidate_0.9.1.zip</A><!-- BBCode End -->
This includes both the fixes described in this thread so far.

I did just a fresh install, I dont get it either ...

it has to be your script not mine, becuase my scripts are brandly NEW and updated!

Ok, but it works for me on a fresh installation - and other people have installed it successfully.

If you are really struggling, here is a patched version of 1.3.4

<!-- BBCode Start --><A HREF="http://www.mcgalliard.org/content/gallery/gallery.1.3.4-cvs-b15_vote.tar.gz" TARGET="_blank">gallery.1.3.4-cvs-b15_vote.tar.gz</A><!-- BBCode End -->

I can't reproduce it. Can you post a link to your site (or PM me) with details on exactly how to get this error. Once I see it, I can try to reproduce it locally.

thanks

Sorry, but I'm not really comfortable with using ssh. Could I do it manually? Thanks for all your help.

Hi!

In case you want to see joan's scripts 'voting' and 'extra_fields' in action, check out my gallery:<!-- BBCode Start --><A HREF="http://www.matadler.de/gallery/" TARGET="_blank">My personal travel pictures</A><!-- BBCode End -->.
Voting is only enabled in this album: <!-- BBCode Start --><A HREF="http://www.matadler.de/gallery/RoadSigns" TARGET="_blank">Funny road signs</A><!-- BBCode End -->, because it is a lot of work to enable it in every single (sub)album...

CU Mathias

Hi, Joan. I have finally been able to patch it by asking my hosting company since they could not grant me access to the patch command in ssh. It seems to be working but I need to confirm with you as I receive a few error messages when the patch was ran. Could you tell me if any of the error messages are important? If so, how do I correct them?

patching file util.php
patching file view_album.php
Hunk #4 succeeded at 295 (offset 38 lines).
Hunk #6 succeeded at 401 (offset 38 lines).
Hunk #7 succeeded at 504 (offset 1 line).
Hunk #8 succeeded at 635 (offset 42 lines).
Hunk #9 succeeded at 650 (offset 6 lines).
Hunk #10 succeeded at 707 (offset 42 lines).
Hunk #11 succeeded at 693 (offset 6 lines).
Hunk #12 succeeded at 752 (offset 42 lines).
Hunk #13 FAILED at 765.
Hunk #14 succeeded at 776 (offset -1 lines).
1 out of 14 hunks FAILED -- saving rejects to file view_album.php.rej
patching file view_photo.php
Hunk #3 succeeded at 256 (offset 39 lines).
Hunk #5 FAILED at 460.
1 out of 5 hunks FAILED -- saving rejects to file view_photo.php.rej
patching file classes/Album.php
patching file classes/AlbumItem.php
patching file css/embedded_style.css.default
Hunk #1 succeeded at 184 with fuzz 1 (offset 132 lines).

BTW, I added some extra codes to the patched files to achieve what I want. Basically, I cut the caption to only show 40 characters and also in the full results view, I replaced the captions with the thumbnail.

Thank you so much for all your effort.

Help l just installed Joans new mod to my gallery and even did a fresh install with here version and l get this error how do l correct this

Fatal error: Call to undefined function: getvoterclass() in /home/sites/site59/web/modules/gallery/util.php on line 1462

l have set permissions on all the folder and did follow the install but still doesnt work any help would be appreciated thanks

dds

Thanks Joan for responding this is the version l downloaded from your previouse post in this section of the forum gallery.1.3.4-cvs-b15_vote.tar i unpacked it and FTP all the contents up and did a clean install setting all the folders to 777 and then ran the setup everything went well but when l go to creat a folder or add a folder it gives me this error is it possible l dont have the right version you mean if so where can l get it l seen this one in a previuse post that you had mentioned that it was a full install with the hack already applied ..

and thank youy in advance for getting back to me so soon looking forward to hearing from you again .

DDS :razz:

ps sorry for my spelling it sucks l know ...lol :eek:

i get

ERROR: requested index [102] out of bounds [101]
Fatal error: Call to a member function on a non-object in /home/picdump/public_html/gallery/classes/Album.php on line 762

here: http://picdump.dhs.org/gallery/daofunnynet?&page=3

it appears to happen only when trying to vote on the third page of the album, voting works on the first two pages.

i've done the change described above to remove the line 90 error, but this persists.

here is another album hosted on my site with voting turned on: http://picdump.dhs.org/gallery/forum
This one allows me to vote no matter which page I'm using.

i am getting this error:

Fatal error: Call to undefined function: isitemowner() in /gallery/reset_votes.php on line 39

where is this function located. I have V1.33 and have done a search but cannot find it. Is it a new function to 1.34?

isowner function appears to works
But i can't find an isItemOwner

the vote button at the bottom of the page doesn't work either (ie. after thumbnails) - this is probably part of the same error.

2 questions.

My first:
Is it possible to setup the polling to be "Show Polling" always?

What I mean is that I don't want to have to tell users that they need to press on "show polling". Can I make a certain album as show polling by default?

My second:
how can I make the visitors be able to vote only once per month?
Is there a setting I need to change for cookies or sesson ID registration somewhere in the code?

Thanks, This is exactly what I was looking for! YOU HAVE MADE MY DAY!
I have started a new site for Electric Flying Wings (R/C) www.ElectricWings.com, and wanted to have a contest. But I could not find anything (script) to make this work. Until my wife said "have the users vote on the best picture since you already have a Photo Album in use.

Then I came here and found exactly what I needed. Installed it, and it works great!

My only problem is that I don't want users to vote more than once per month.

Regards,

NPereira

1) Sure. Edit view_album.php and find

if (!canVote())
{
        $showPolling=false;
}
else if (!isset($showPolling))
{
        $showPolling = $gallery->session->albumPolling[$gallery->album->fields["name"]];
        if (!isset($showPolling))
        {
                $showPolling = true;
        }
}

and replace it with

if (!canVote())
{
        $showPolling=false;
}
else if (!isset($showPolling))
{
        $showPolling=true;
}

and delete

else if (canVote())
{
        $adminCommands .= '<a href="'.  makeGalleryUrl("view_album.php",
                array("set_albumName" => $gallery->session->albumName,
                "showPolling" => true)).  '"><nobr>[show polling]</nobr></a>';
}

2) There's no date information recorded with the votes. You'd have to write it yourself. I'd just make only registered users allowed to vote, and have a new competition every month, but that's me.

joan, is there a version that only does voting/polling of the albums and not the photos? Also for it to possibly rank them in order of highest votes.

thanks.

I'd like to upgrade to 1.3.4-RC3, but the link to this patch seems to be dead. is there an updated version of this patch available? thanks.

Joan,

Is this the lastest release of the vote candidate?

Let me know if there is one better!

Nelson